Fix/cli offset #2591
Merged
Fix/cli offset #2591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipeelia
requested changes
Feb 15, 2022
includes/classes/IndexHelper.php
Outdated
Comment on lines
656
to
659
| /* translators: 1. Number of objects indexed */ | ||
| esc_html__( 'Skipping %1$d %2$s posts...', 'elasticpress' ), | ||
| $from, | ||
| esc_html( strtolower( $indexable->labels['plural'] ) ) |
There was a problem hiding this comment.
@oscarssanchez a few things in this block:
- The "translators" comment should be aligned with the esc_html__ call (an example here)
- It is missing the second placeholder description
- If I'm reading this right, the
%2$swill become "posts", "users", etc., right? If so, won't it becomeSkipping 100 posts posts...(duplicated posts)?
There was a problem hiding this comment.
Hi @felipeelia thanks i've fixed here a95e35d and here cf7cf41
includes/classes/IndexHelper.php
Outdated
| @@ -648,10 +648,34 @@ function( $item ) { | |||
| } | |||
| } | |||
|
|
|||
| $from = $this->index_meta['offset'] - count( $this->current_query['objects'] ); | |||
There was a problem hiding this comment.
Instead of placing this entire code inside of index_next_batch(), wouldn't it be better to add it to index_objects(), right before we actually start indexing things?
There was a problem hiding this comment.
Thanks @felipeelia I've moved this code here: 993fe3b
This was referenced Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR changes the current message that's being displayed when a WP CLI index is triggered with a specified offset. Introduces
index_meta['skip_message_shown']to check whether we have shown theSkipping X...message.Closes #2557
Alternate Designs
Possible Drawbacks
Verification Process
Checklist:
Changelog Entry
Credits
Props @